Basic parsing of events #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separates only an event's tag from its data.
... but happens regularly during test runs.
| public class Event { | ||
|
|
||
| private String tag; | ||
| private HashMap<String, Object> data; |
There was a problem hiding this comment.
i would just use Map here no reason to be more specific.
There was a problem hiding this comment.
Thanks, fixed with 9aec7a5.
|
Besides the line i commented on LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings in basic parsing of events into objects. So far we are only separating an event's
tagfrom itsdatathough. This is already very helpful in order to filter the event stream for interesting events. Apart from that there is two small commits affecting the event stream tests. Please have a look, @lucidd, thank you!