Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add saltssherror for better error reporting #292

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

lucidd
Copy link
Member

@lucidd lucidd commented May 18, 2021

This adds a generic salt ssh error that will forward retcode and stderr returned in the salt ssh result in case the retcode is not 0.

@lucidd lucidd force-pushed the ssherrorhandling branch 2 times, most recently from 4cb2c67 to f0a3c28 Compare May 20, 2021 09:23
@lucidd lucidd requested a review from renner May 21, 2021 12:25
Copy link
Member

@renner renner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me as it is. Maybe some new unit tests could be useful for testing the SaltSSHError instances, if that is feasible.

@renner renner added this to the v0.19.0 milestone May 25, 2021
@lucidd lucidd merged commit 34d9dd1 into master Oct 21, 2021
@lucidd lucidd deleted the ssherrorhandling branch October 21, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants