Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git module added (status, add, commit, branch) #263

Merged
merged 5 commits into from
Mar 28, 2019
Merged

Conversation

ravega
Copy link
Contributor

@ravega ravega commented Mar 17, 2019

This Git module adds the following four git commands, status, add, commit and branch from the salt list of supported git module commands.

Copy link
Member

@renner renner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ravega, thanks for your contribution. Could you please add a description to your PR, every PR should have a description!

assertEquals("git.add", call.getPayload().get("fun"));

// Test with a successful response
mockOkResponseWith(JSON_ADD_ERROR_RESPONSE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem to be accurate here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @renner, thanks for your comments, I just uploaded a fix on the comment to match the received response.

@renner renner requested a review from lucidd March 20, 2019 15:35
@renner renner added this to the Version 0.16.0 milestone Mar 20, 2019
@renner renner merged commit 41d57c8 into SUSE:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants