Add test to timezone.get_offset API call #261
Conversation
Signed-off-by: Drago8888 <rjmateus1985@gmail.com>
Signed-off-by: drago8888 <rjmateus1985@gmail.com>
|
Challenge from Ricardo Mateus |
| assertEquals(JsonNull.INSTANCE, | ||
| ((JsonParsingError) response.get("minion1").error().get()).getJson()); | ||
|
|
||
| // Test for successful responses |
There was a problem hiding this comment.
I would suggest to test each case separately here, would you maybe want to move this second use case into a separate method?
There was a problem hiding this comment.
I agree with you, I think each case should be in a separated method and that was my first approach.
The reason behind my change of approach was to keep the consistency with the rest of the project test, with one test method per function with several scenarios.
However in this case following the right way instead of consistency seems not to bring any harm to the future of the project, therefore I will split the test into two as suggested.
| TimezoneTest.class.getResourceAsStream( | ||
| "/modules/timezone/null_response.json")); | ||
|
|
||
| private static final String JSON_GETOFFESET_OK_RESPONSE = ClientUtils.streamToString( |
There was a problem hiding this comment.
There is a typo in this name, should be JSON_GETOFFSET_OK_RESPONSE.
|
|
||
| private static final String JSON_GETOFFESET_OK_RESPONSE = ClientUtils.streamToString( | ||
| TimezoneTest.class.getResourceAsStream( | ||
| "/modules/timezone/getOffset_ok.json")); |
There was a problem hiding this comment.
May I suggest to rename that file in order to avoid mixing underscore with camel case notations to get_offset_ok.json?
Signed-off-by: drago8888 <rjmateus1985@gmail.com>
Signed-off-by: drago8888 <rjmateus1985@gmail.com>
Signed-off-by: drago8888 <rjmateus1985@gmail.com>
Signed-off-by: Drago8888 rjmateus1985@gmail.com