Add pillar and data match modules #259
Conversation
brunobottazzini
force-pushed
the
new_modules
branch
from
123f8e7
to
0dd996d
Compare
This patch also includes documentation for the methods inside the Match module class.
brunobottazzini
force-pushed
the
new_modules
branch
from
0dd996d
to
6a5f2c9
Compare
There was a problem hiding this comment.
Hey @brunobottazzini, thank you for the contribution. The patch looks good, only added two minor suggestions in the comments.
| public WireMockRule wireMockRule = new WireMockRule(MOCK_HTTP_PORT); | ||
|
|
||
| static final String JSON_CONFIG_MANAGE_MODE = ClientUtils.streamToString( | ||
| FileTest.class.getResourceAsStream("/modules/match/match_output.json")); |
There was a problem hiding this comment.
Is there a reason why the name was chosen as JSON_CONFIG_MANAGE_MODE ? I am only curious why it was not rather named JSON_MATCH_OUTPUT or similar.
There was a problem hiding this comment.
Hello Renner,
Sorry in the delay to answer your message. I was on Vacation :)...
You are right. I will change the name and update the PR. Today....
Thank you
| * Return True if the minion matches the given pillar target. | ||
| * The delimiter argument can be used to specify a different delimiter. | ||
| * @param tgt | ||
| * @param delimiter |
There was a problem hiding this comment.
As you added javadoc comments I might suggest you to also add for completeness short descriptions of all the parameters as it is usually done, for example:
@param tgt pillar target
@param delimiter optional different delimiterThere was a problem hiding this comment.
I will add it.
There was a problem hiding this comment.
@renner, I just pushed everything... I hope it can me merged :)
|
Sorry for the long delay @brunobottazzini, finally merged it. |
the Match module class.