salt.modules.cmdmod additions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucidd
reviewed
Feb 10, 2019
| */ | ||
| public class CmdExecCodeAll { | ||
| public class CmdArtifacts { |
There was a problem hiding this comment.
i would suggest naming this something like CmdResult since we use the Result suffix quite a bit already for values returned by salt.
There was a problem hiding this comment.
Renamed to CmdResult as suggested.
| @@ -29,6 +31,13 @@ private Cmd() { } | |||
| new TypeToken<String>(){}); | |||
| } | |||
|
|
|||
| public static LocalCall<CmdArtifacts> runAll(String cmd) { | |||
| LinkedHashMap<String, Object> args = new LinkedHashMap<>(); | |||
There was a problem hiding this comment.
i think we could replace this in all methods with Collections.emptyMap.
There was a problem hiding this comment.
Replaced empty map creation with Collections.emptyMap(), and also replaced single pair map creations with Collections.singletonMap().
Renamed CmdArtifacts to CmdResult, replaced empty map creation in Cmd with Collections.emptyMap()
renner
approved these changes
Feb 27, 2019
lucidd
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
cmd.run_all,cmd.scriptandcmd.script_retcodebindings tocom.suse.salt.netapi.calls.modules.Cmd. Added related tests.Moved common stub logic in
com.suse.salt.netapi.calls.modules.CmdTestto a separate method (mockOkResponseWith).