Enable working with API served on a sub-path #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renner
force-pushed
the
master-issue-237
branch
from
f153c80
to
10ec160
Compare
lucidd
approved these changes
Oct 19, 2018
This should fix #237
renner
force-pushed
the
master-issue-237
branch
from
10ec160
to
bc92b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #237 by removing leading slashes from API endpoints when calling
uri.resolve(). The base URL now requires to have a trailing slash, so we add it in case it does not.@danh-fissara, it would be great if you could give this a try so we know that it solves your problem. Thanks!