AbstractEventStream: use copy-on-write list implementation #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified in Uyuni that the previous implementation might lead to excessive monitor contention over the list, especially since iteration (in
notifyListeners
) requires a monitor.In the application that I am looking at, we call
notifyListeners
from multiple threads, and this results in all threads but one being blocked while the notification is in progress.This change uses a different synchronized Collection which has an extra cost on writes but never blocks reads.