EventStream refactoring #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moio
force-pushed
the
event-stream-refactoring
branch
from
f23532f
to
1677555
Compare
|
JFI: I pushed a rebased version of these changes against v0.14 in https://github.com/SUSE/salt-netapi-client/tree/v0.15.0-event-stream-refactoring I am not opening a PR unless you tell me otherwise. |
lucidd
approved these changes
Aug 27, 2018
renner
approved these changes
Aug 27, 2018
| protected void clearListeners(int code, String phrase) { | ||
| synchronized (listeners) { | ||
| listeners.stream() | ||
| .forEach(listener -> listener.eventStreamClosed(code, phrase)); |
There was a problem hiding this comment.
Just a nitpick: there is different indentation used here and above, maybe those expressions would even fit on one line? By the way: it seems that it is possible to omit the stream() and call forEach() directly on Java 8 Iterables.
moio
force-pushed
the
event-stream-refactoring
branch
from
1677555
to
53a0bae
Compare
|
I added one extra commit to handle the case in which event listeners are removed from some method called by I am merging as soon as Travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of 5 refactorings to detach
EventStreamfrom its WebSocket implementation and allow alternative implementations.This is needed in order to replace reading from WebSockets completely in Uyuni where we plan to read them from a Postgres database filled by a custom Salt Engine.
Best reviewed commit-by-commit.