Enable "Pkg.InfoInstalled" to return all installed package versions #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucidd
reviewed
May 18, 2018
| * @param packages optional give package names, otherwise return info about all packages | ||
| * @return the call | ||
| */ | ||
| public static LocalCall<Map<String, Xor<Info, List<Info>>>> infoInstalled(List<String> attributes, |
There was a problem hiding this comment.
like discussed i would remove the allVersions parameter here and pass always true since the return type only makes sense for true in case you would pass false you might as well use the old function with the simpler return type.
meaksh
force-pushed
the
master-add-pkg_installed-all-versions
branch
from
41d3c10
to
4730db4
Compare
|
@lucidd changes done! |
lucidd
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
Pkg.InfoInstalledcall to get all installed package versions on the minion (instead only the latest version) by introducing theallVersionsparameter forPkg.InfoInstalled.Salt
all_versionsparameter forpkg.info_installedhas been introduced here: saltstack/salt#47678 (approved but not yet merged)