Change parameter name: 'expr_form' to 'tgt_type' #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucidd
approved these changes
Apr 20, 2018
|
This is a bit dangerous. Does salt 2016.11.4 support it? If not, this lib requires minimal salt 2018? Or 2017.7? You should document it somewhere. |
|
True, @mcalmer, after we merge this there is no backwards compatibility. I will check the minimal required Salt version and document it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to fix #227:
expr_formis deprecated and will be replaced withtgt_typeeverywhere.