Engine events #230
Merged
Engine events #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renner
approved these changes
Apr 10, 2018
| */ | ||
| public class EngineEvent { | ||
| private static final Pattern PATTERN = | ||
| Pattern.compile("^salt/engines/([^/]+)/(.*)$"); |
There was a problem hiding this comment.
Maybe there is no need to break this line (and maybe others below) anymore, max line length for checkstyle was meanwhile increased to 120 characters!
| private final JsonElement data; | ||
|
|
||
| /** | ||
| * Creates a new BeaconEvent |
There was a problem hiding this comment.
This is not a BeaconEvent anymore, please update to EngineEvent.
.gitignore
Outdated
| @@ -15,3 +15,4 @@ | |||
|
|
|||
| # OSX Metadata | |||
| .DS_Store | |||
| /bin/ | |||
There was a problem hiding this comment.
Actually when you configure your eclipse project as a "Maven Project", which I would recommend you as it makes building and tracking dependencies easier, there is no need for adding the bin folder: the output folder will be ./target/classes per default which is already gitignored.
engine events are somewhat special since they can be fired from either a master or a minion. Add an event class to handle them.
|
Merged it, thank you @cbosdo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding engine event class and its test handling both master and minion engine events.