Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on javax.xml.bind any longer #222

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Do not depend on javax.xml.bind any longer #222

merged 1 commit into from
Nov 22, 2017

Conversation

renner
Copy link
Member

@renner renner commented Nov 22, 2017

For JDK9 javax.xml.bind is deprecated to be removed in a future version. Now as JDK8 finally includes Base64 encoding and decoding we should make use of that in order to avoid having to add an additional external library in the future.

Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (previous comment was a mistake)

Copy link
Member

@lucidd lucidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@renner renner merged commit 88a609f into master Nov 22, 2017
@renner renner deleted the master-base64 branch November 22, 2017 15:27
@renner renner added this to the Version 0.14.0 milestone Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants