Async and non-blocking HTTP backend #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is about replacing the existing HTTP client backend (that can run on either the Apache HTTP client or the JDK classes) with one that works in a non-blocking fashion, in this case the Apache HttpAsyncClient. The outcome of this is that we can actually benefit from the concurrency features of Java 8, especially CompletableFuture. All the main library methods will then return a CompletionStage containing the result instead of just the result. This is why we are targeting the version 1.0.0 milestone with this patch.