Async and non-blocking HTTP backend #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renner
force-pushed
the
master-api-cleanup
branch
from
2c0d3d7
to
0a70fa5
Compare
renner
force-pushed
the
master-async-http-client
branch
from
c626990
to
6e80093
Compare
renner
changed the title
lucidd
force-pushed
the
master-async-http-client
branch
2 times, most recently
from
41e7ab7
to
9419ebc
Compare
renner
commented
Jul 2, 2018
| this.executor = executor; | ||
|
|
||
| // TODO: Replace connectionFactory with this | ||
| this.asyncConnectionFactory = new HttpAsyncClientConnectionFactory(config); |
There was a problem hiding this comment.
Please remove the TODO comment here as the connectionFactory is gone now.
lucidd
force-pushed
the
master-async-http-client
branch
2 times, most recently
from
5b585d9
to
6717d32
Compare
renner
force-pushed
the
master-async-http-client
branch
from
6717d32
to
a0488ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is about replacing the existing HTTP client backend (that can run on either the Apache HTTP client or the JDK classes) with one that works in a non-blocking fashion, in this case the Apache HttpAsyncClient. The outcome of this is that we can actually benefit from the concurrency features of Java 8, especially CompletableFuture. All the main library methods will then return a CompletionStage containing the result instead of just the result. This is why we are targeting the version 1.0.0 milestone with this patch.