Major API cleanup #170
Merged
Major API cleanup #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renner
force-pushed
the
master-api-cleanup
branch
from
03616c7
to
f087cbd
Compare
renner
force-pushed
the
master-api-cleanup
branch
from
0d0e402
to
2c0d3d7
Compare
smatei
pushed a commit
to smatei/salt-strike
that referenced
this pull request
Jan 30, 2018
SUSE/salt-netapi-client#228 The getMinions and getMinionDetails methods will be removed (SUSE/salt-netapi-client#170), so replaced that with grains.items
lucidd
approved these changes
Jun 27, 2018
renner
force-pushed
the
master-api-cleanup
branch
from
2c0d3d7
to
0a70fa5
Compare
|
Finally merged, after 2 years! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is going to bring a major API cleanup: Some of the Salt API endpoints are only shortcuts to certain execution modules, e.g. the
/minionsor/jobsendpoints. We would like to unify and simplify the API of this library by removing support for targeting all the Salt API endpoints. Instead all calls will use either/runor/assuming that all functionality can be implemented by using those endpoints with one of eitherLocalCall,WheelCallorRunnerCall.