Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop base images #376

Merged
merged 2 commits into from
May 24, 2024
Merged

Drop base images #376

merged 2 commits into from
May 24, 2024

Conversation

ricardobranco777
Copy link
Collaborator

Drop base images as it creates an issue where dependencies introduced via requirements.txt are not properly tested in CI.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.17%. Comparing base (8ec0cb6) to head (c61d2e6).
Report is 1 commits behind head on master.

Files Patch % Lines
ocw/lib/emailnotify.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          22       22           
  Lines        1676     1676           
=======================================
  Hits         1310     1310           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmorodskyi
Copy link
Collaborator

just for the reference PR where base image was introduced https://github.com/SUSE/pcw/pull/350/files

@asmorodskyi asmorodskyi merged commit 8aa4cf7 into SUSE:master May 24, 2024
9 checks passed
@ricardobranco777 ricardobranco777 deleted the dropbase branch May 24, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants