Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: Check if version.tags is None #355

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

ricardobranco777
Copy link
Collaborator

Fix for

Traceback (most recent call last):
  File "/pcw/ocw/lib/cleanup.py", line 21, in cleanup_run
    Azure(namespace).cleanup_all()
  File "/pcw/ocw/lib/azure.py", line 125, in cleanup_all
    self.cleanup_gallery_img_versions()
  File "/pcw/ocw/lib/azure.py", line 197, in cleanup_gallery_img_versions
    if Instance.TAG_IGNORE in version.tags:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2ec1254) 78.59% compared to head (d90e9c2) 78.59%.
Report is 4 commits behind head on master.

Files Patch % Lines
ocw/lib/azure.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files          22       22           
  Lines        1653     1653           
=======================================
  Hits         1299     1299           
  Misses        354      354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ocw/lib/azure.py Outdated Show resolved Hide resolved
@asmorodskyi
Copy link
Collaborator

Thanks Ricardo ! Sorry for delay with review was busy with other things

@asmorodskyi asmorodskyi merged commit b2805bb into SUSE:master Feb 25, 2024
9 checks passed
@ricardobranco777 ricardobranco777 deleted the skip_none_tags branch March 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants