-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate more French words into English #373
Conversation
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@@ -142,7 +142,7 @@ | |||
'label_trans_key' => 'Label', | |||
'customer_trans_key' => 'Customer', | |||
'status_trans_key' => 'Status', | |||
'statu_trans_key' => 'Statu', | |||
'statu_trans_key' => 'Status', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot accept this line, there is statu and status with an "s" for the plural (line just before) if I maintain, it is duplicates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, But I guess there is no Statu in English, What can we do with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave the discussion for future. This line is reverted, please take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state or progress would be more appropriate? I validate the pull request and we will see how it is used later,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess state and status are pretty similar. The only issue is that they are not related like it is in French.
I can totally understand the meaning of Statu in UI, even though it's not English. Let's keep it as it is.
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
There are some more words can be translated into English