Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redundant conditions in OpportunitiesController #368

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

sunxiaoguang
Copy link
Contributor

There are two redundant conditions in OpportunitiesController.php:246

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@SMEWebify SMEWebify self-assigned this Apr 29, 2024
@SMEWebify SMEWebify added the invalid This doesn't seem right label Apr 29, 2024
@SMEWebify SMEWebify added this to In progress in v1.09 - Pieris ergane via automation Apr 29, 2024
Copy link
Owner

@SMEWebify SMEWebify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunxiaoguang nice catch, partialy true

These are the following variables that should be controlled

$accounting_payment_conditions = AccountingPaymentConditions::select('id')->where( 'default', 1)->first(); 
$accounting_payment_methods = AccountingPaymentMethod::select('id')->where( 'default', 1)->first(); 
$accounting_deliveries = AccountingDelivery::select('id')->where( 'default', 1)->first(); 

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@sunxiaoguang
Copy link
Contributor Author

@sunxiaoguang nice catch, partialy true

These are the following variables that should be controlled

$accounting_payment_conditions = AccountingPaymentConditions::select('id')->where( 'default', 1)->first(); 
$accounting_payment_methods = AccountingPaymentMethod::select('id')->where( 'default', 1)->first(); 
$accounting_deliveries = AccountingDelivery::select('id')->where( 'default', 1)->first(); 

I see. Updated to control by these three variables. PTAL

@SMEWebify SMEWebify self-requested a review April 29, 2024 12:50
Copy link
Owner

@SMEWebify SMEWebify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@SMEWebify SMEWebify merged commit 825c1b9 into SMEWebify:WEM-2.0 Apr 29, 2024
1 check passed
v1.09 - Pieris ergane automation moved this from In progress to Done Apr 29, 2024
@SMEWebify SMEWebify changed the title Remove redundant conditions in OpportunitiesController Change redundant conditions in OpportunitiesController Apr 29, 2024
@SMEWebify SMEWebify moved this from Done to Integrated on demo site in v1.09 - Pieris ergane Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
No open projects
v1.09 - Pieris ergane
Integrated on demo site
Development

Successfully merging this pull request may close these issues.

None yet

2 participants