Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting socket-tuple attributes doesn't catch value errors #12

Closed
goodboy opened this issue Apr 22, 2016 · 0 comments
Closed

Setting socket-tuple attributes doesn't catch value errors #12

goodboy opened this issue Apr 22, 2016 · 0 comments
Labels
bug

Comments

@goodboy
Copy link
Member

goodboy commented Apr 22, 2016

Oh man...

In [27]: ua = pysipp.client(proxyaddr='10.10.8.88')

In [28]: ua.proxyaddr                              
Out[28]: ('1', '0')

And it's due to the (probably) more then necessary property wrapping here.
We should really throw a ValueError: too many values to unpack or something similar.
@goodboy goodboy added the bug label Apr 22, 2016
@goodboy goodboy changed the title Setting socket-tuple attributes is broken Setting socket-tuple attributes doesn't catch value errors Apr 22, 2016
goodboy added a commit that referenced this issue Jul 5, 2019
@goodboy
Raise ValueError on non-tuple assignment
c275334 
These fancy tuple-attribute-properties are supposed to be strictly
assigned tuple types; let's enforce that.

Resolves #12
goodboy added a commit that referenced this issue Jul 5, 2019
@goodboy
Further fixes
4bfe5db 
As per the change for #20, handle the case where the user passes in
a `defaults` kwarg to `pysipp.scenario` and use it override the normal
template. To fully solve #12 also support assignment of `None` which
results in the tuple attribute taking a value of `(None, None)`
implicitly.
goodboy added a commit that referenced this issue Jul 27, 2019
@goodboy
Further fixes
2652f52 
As per the change for #20, handle the case where the user passes in
a `defaults` kwarg to `pysipp.scenario` and use it override the normal
template. To fully solve #12 also support assignment of `None` which
results in the tuple attribute taking a value of `(None, None)`
implicitly.
goodboy added a commit that referenced this issue Dec 24, 2020
@goodboy
Raise ValueError on non-tuple assignment
e8a819a 
These fancy tuple-attribute-properties are supposed to be strictly
assigned tuple types; let's enforce that.

Resolves #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goodboy