W3-A3__sass-and-jquery Zach Gordon/Lyle Scott (FINAL) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side as HTML sections are created.
Add title and design from different branch
…t/advanced-presentation__W2-A2 into w3-a3__sass-and-jquery
…t/advanced-presentation__W2-A2 into w3-a3__sass-and-jquery
LyleCharlesScott
changed the title
LyleCharlesScott
changed the title
|
Breadcrumbs to find the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blackfalcon, @miketierney, @jedfoster
We did a significant amount of learning and refactoring. It was uphill, as we kept trying to use SASS and it repeatedly broke things that were working previously! For the most part we took it as a learning exercise and took the practice. For example, _responsive-nav.scss section broke the nav bar repeatedly when we tried to use SASS shortcuts, although it was working fine previously with CSS. So we never used our refactoring attempts on that section.
The JS code for the pricing tables was done by Lyle. The code for the progress bars in the about section and the filter in the Portfolio section were both done by Zach.