Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class names added to sections #985

Merged
merged 2 commits into from
Aug 4, 2016
Merged

class names added to sections #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9bd28
class name added to section markup
junaidrsd Aug 4, 2016
a43c7f3
fix the test
junaidrsd Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/app/views/element-fullscreen.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
<i class="fa fa-arrow-right"></i>
</a>
</div>
<shadow-dom>
<div ng-bind-html="markup | addWrapper | unsafe" dynamic-compile></div>
<shadow-dom class="section-fullscreen">
<div class="section-markup-wrapper" ng-bind-html="markup | addWrapper | unsafe" dynamic-compile></div>
</shadow-dom>
4 changes: 2 additions & 2 deletions lib/app/views/partials/section.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h1 class="sg">
</a>
</div>
<shadow-dom id="section-{{section.reference}}-modifier-{{mod.id}}-render-markup">
<div ng-bind-html="mod.renderMarkup | setModifierClass: mod.className | setVariables: variables | addWrapper | unsafe" dynamic-compile></div>
<div class="section-markup-wrapper" ng-bind-html="mod.renderMarkup | setModifierClass: mod.className | setVariables: variables | addWrapper | unsafe" dynamic-compile></div>
</shadow-dom>
</div>
<div ng-repeat-end></div>
Expand All @@ -40,7 +40,7 @@ <h1 class="sg">
</div>

<shadow-dom id="section-{{section.reference}}-render-markup">
<div ng-bind-html="section.renderMarkup | setVariables: variables | addWrapper | unsafe" dynamic-compile></div>
<div class="section-markup-wrapper" ng-bind-html="section.renderMarkup | setVariables: variables | addWrapper | unsafe" dynamic-compile></div>
</shadow-dom>
</div>

Expand Down
2 changes: 1 addition & 1 deletion test/angular/functional/element-fullscreen.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('element-fullscreen template', function() {
describe('component markup', function() {

it('should be wrapped in shadow-dom element', function() {
expect(template).to.match(/<shadow-dom>[\s\S]*<\/shadow-dom>/);
expect(template).to.match(/<shadow-dom [\s\S]*>[\s\S]*<\/shadow-dom>/);
});

describe('should have directive', function() {
Expand Down