Configurable dependencies #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also made some small tweaks to style guide app markup docs.
* upgrade-packages: Fixed casing issue causing failure to load ngProgress.
* upgrade-packages: Removed describe.only call in app.test.js (woops) Added testing around AppCtrl.
* upstream/master: Link to a blog post about advanced adjustment Release 1.0.0 Test for !optional in SCSS. Fix SC5#757 Test for @supports in CSS Return server instance when calling styleguide.server() Use new version of gonzales and traverse for LESS optimize filter setVariables Release 0.3.47 update kss markup of styleguide app styles test coverage improved main section view Fix typo fix css for search field Link to "Advanced techniques for the SC5 styleguide generator" Additional links in the documentation
* master: Fixed the angular-mocks dependency to match the base angular dependency version.
|
The coverage decrease here is really small so I'm hoping it's acceptable. Otherwise, I'm not sure of the best way to test my changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new configuration parameter (additionalNgDependencies) which allows users of the styleguide to inject dependencies while bootstrapping the style guide rather than during lazy load of components. Usage details have been added to the README.
This became necessary when trying to integrate the sc5-styleguide with a component library that used ngMaterial because ngMaterial doesn't play nicely with ocLazyLoad. See this GitHub issue for more details.
Testing done
We've been using this fork on our project for about a month and haven't noticed any issues.
Thanks