Upgrade packages #933
Merged
Upgrade packages #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include highlightjs directly since it is no longer a bower dependency of angular-highlight. - Add language hints for hljs.
| "angular-scroll": "0.7.0", | ||
| "lodash": "~3.9.3", | ||
| "custom-event": "~0.1.0" | ||
| "angular-mocks": "^1.5.5", |
There was a problem hiding this comment.
I noticed that you have fixed your versions to specific version numbers. However, I've used the caret notation to fix packages to the 1.x versions. I could easily pull those back out if that's your preference.
…json. - Fixed jshint errors in appCtrl - Modified test/karma.conf.js to point to the correct location for ui-router. - Removed resolution section in bower.json since it is no longer necessary after upgrading all packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade all packages to the newest versions. This includes upgrading usage of
ngProgressandangular-highlight.I had to upgrade the version of Angular a few weeks ago and upgraded all other packages at the same time. I noticed yesterday that you just merged in the upgrade to Angular 1.5.5 so hopefully you're also interested in upgrading the rest of the packages.
I'll add some inline notes as well for discussion purposes.
Testing done
I've tested these changes by running both versions of the demo and comparing them to each other. I've also been running the upgraded version with my own style guide for a couple weeks.