Run clean task before build to remove previous build results #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simkall
force-pushed
the
add-clean-task-to-build-process
branch
from
c8a85f6
to
18b06d9
Compare
| @@ -121,7 +127,9 @@ gulp.task('dev', ['dev:doc', 'dev:static', 'dev:applystyles', 'dev:generate'], ( | |||
| gulp.watch('lib/styleguide.js', ['dev:generate']); | |||
| }); | |||
|
|
|||
| gulp.task('build', ['sass', 'js:app', 'js:vendor', 'html', 'assets']); | |||
| gulp.task('build', ['clean-dist'], () => { | |||
| gulp.start(['sass', 'js:app', 'js:vendor', 'html', 'assets']); | |||
There was a problem hiding this comment.
gulp.start? That's new to me - and even Gulp API documentation does not have it documented. I believe run-sequence is way to go instead (to ensure clean-dist runs before others): https://www.npmjs.com/package/run-sequence
There was a problem hiding this comment.
Related: gulpjs/gulp#426 (comment)
There was a problem hiding this comment.
Yeah I just found the same comment. I´m not sure from where I found the start command but clearly it shouldn't be used.
| @@ -121,7 +127,11 @@ gulp.task('dev', ['dev:doc', 'dev:static', 'dev:applystyles', 'dev:generate'], ( | |||
| gulp.watch('lib/styleguide.js', ['dev:generate']); | |||
| }); | |||
|
|
|||
| gulp.task('build', ['sass', 'js:app', 'js:vendor', 'html', 'assets']); | |||
| gulp.task('buildDist', ['sass', 'js:app', 'js:vendor', 'html', 'assets']); | |||
There was a problem hiding this comment.
Could you rename this task into build:dist. We use similar naming, with : in other tasks.
varya
added a commit
that referenced
this pull request
Nov 24, 2015
Run clean task before build to remove previous build results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem #840 fixes would have been noticed a lot sooner if previous build results were cleared before the next build.