Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using less variable interpolation causes Gonzales error #577

Open
kr3l opened this issue Apr 15, 2015 · 5 comments
Open

Using less variable interpolation causes Gonzales error #577

kr3l opened this issue Apr 15, 2015 · 5 comments

Comments

@kr3l
Copy link
Contributor

kr3l commented Apr 15, 2015

Hi,

I have some less styles using variable interpolation, as shown below:

.funnel-based-color(@property: border-left-color, @funnel-attribute: data-annotation-funnel) {
  &[@{funnel-attribute}=TranscriptAnnotation] {
    border-color: red;
  }
}

When trying to generate the styleguide (v0.3.11), it says

Parsing error: Please check the validity of the block starting from line #undefined

Gonzales PE version: 3.0.0-12

Note: I tried surrounding the code with

//styleguide:ignore:start
...
//styleguide:ignore:end

to at least be able to generate the Styleguide without the styles causing the parse error, but the same error occurs.

@hannu
Copy link
Contributor

hannu commented Apr 15, 2015

I have reported similar issue to gonzales-pe: tonyganch/gonzales-pe#60.
Ignore tags should work as a workaround. I will have a look why input is not ignored.

hannu pushed a commit to hannu/sc5-styleguide that referenced this issue Apr 15, 2015
@hannu
Copy link
Contributor

hannu commented Apr 15, 2015

One parser module (kss-splitter) didn't respect ignored block. The next release will fix this so you can use ignore tags as a workaround solution.

@kr3l
Copy link
Contributor Author

kr3l commented Apr 15, 2015

thanks @hannu

junaidrsd pushed a commit that referenced this issue Apr 15, 2015
Respect ignored blocks in kss-splitter, fixes #577
@hannu hannu closed this as completed in 01b261e Apr 16, 2015
@karlhorky
Copy link
Contributor

@hannu It looks like interpolation was recently fixed in the dev branch of gonzales-pe.

Should we reopen this issue to track upgrading sc5-styleguide with this fix or should I start a new issue for that?

@hannu
Copy link
Contributor

hannu commented Aug 24, 2015

Yes. Lets reopen this issue for simplicity until gonzales-pe is upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants