Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pipeline from mem-fs@4 #229

Merged
merged 2 commits into from
Oct 15, 2023
Merged

use pipeline from mem-fs@4 #229

merged 2 commits into from
Oct 15, 2023

Conversation

mshima
Copy link
Collaborator

@mshima mshima commented Oct 12, 2023

  • use pipeline from mem-fs.
  • bump node to v18.0.0 matching mem-fs.
  • add coverage.
  • move mem-fs to peer-dependencies. mem-fs is not instantiated directly, but the editor requires specific features from mem-fs.
    Having it in peer dependencies is more appropriate.
  • commitFileAsync used to add a missing file to mem-fs, it's not require anymore since mem-fs now recreates the fs state using emitted files.
  • decouple commitFileAsync from mem-fs-editor instance.
    Can be used to create custom commit pipeline without mem-fs-editor instance:
await memFs.pipeline(createCommitTransform());
  • re-export { PipelineOptions, FileTransform } for convenience.

@mshima mshima requested a review from SBoudrias October 13, 2023 11:23
@mshima mshima merged commit e5f563a into SBoudrias:master Oct 15, 2023
7 checks passed
@mshima mshima deleted the pipeline2 branch October 15, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants