fix: dump with filter regression (#218)

SBoudrias · May 9, 2023 · 2e7a021 · 2e7a021
1 parent ba9f1ec
commit 2e7a021
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/__tests__/__snapshots__/dump.spec.ts.snap b/__tests__/__snapshots__/dump.spec.ts.snap
@@ -43,3 +43,12 @@ exports[`#dump() > with a glob pattern > should return files that matches the pa
   },
 }
 `;
+
+exports[`#dump() > with custom filter > should match snapshot 1`] = `
+{
+  "foo/not-committed": {
+    "contents": "not-committed",
+    "state": "modified",
+  },
+}
+`;
diff --git a/__tests__/dump.spec.ts b/__tests__/dump.spec.ts
@@ -42,6 +42,12 @@ describe('#dump()', () => {
     expect(fs.dump(output)).toMatchSnapshot();
   });
 
+  describe('with custom filter', () => {
+    it('should match snapshot', () => {
+      expect(fs.dump(output, file => file.path.endsWith('not-committed'))).toMatchSnapshot();
+    });
+  });
+
   describe('with a glob pattern', () => {
     it('should return files that matches the pattern and have state or stateCleared', () => {
       expect(fs.dump(output, '**/*committed')).toMatchSnapshot();

diff --git a/src/actions/dump.ts b/src/actions/dump.ts
@@ -21,7 +21,7 @@ export default function <EditorFile extends MemFsEditorFile>(
   const filterFile: (file: EditorFile, cwd: string) => boolean =
     typeof filter === 'string'
       ? (file: MemFsEditorFile) => defaultDumpFilter(file) && minimatch(file.path, filter)
-      : defaultDumpFilter;
+      : filter ?? defaultDumpFilter;
 
   return Object.fromEntries(
     this.store