-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inquirer): add AbortSignal support #1524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1524 +/- ##
=======================================
Coverage ? 98.25%
=======================================
Files ? 37
Lines ? 2403
Branches ? 653
=======================================
Hits ? 2361
Misses ? 36
Partials ? 6 ☔ View full report in Codecov by Sentry. |
I took the liberty to:
I'm very happy with the state of that feature inside |
a6768b2
to
44e6b68
Compare
855278c
to
0140d6f
Compare
|
This PR now adds Signal support to the |
Did you look into polyfilling AborySignal.any() yet? |
There is AbortSignal polyfills but not |
af12865
to
9c65215
Compare
9c65215
to
552414c
Compare
Great! Thanks for all the back and forth on this one 🤞🏻 |
Fixes #1521