Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox instructions disappears on space selection #1217

Closed
shinebayar-g opened this issue May 4, 2023 · 4 comments · Fixed by #1381
Closed

Checkbox instructions disappears on space selection #1217

shinebayar-g opened this issue May 4, 2023 · 4 comments · Fixed by #1381

Comments

@shinebayar-g
Copy link

shinebayar-g commented May 4, 2023

Pressing i or a works as expected. But selecting item with space, removes instructions.
image
image
image

@SBoudrias
Copy link
Owner

Hey! This is done on purposes to reduce weight on the screen once we assume a user understands how to operate the prompt.

Does it cause a problem? Would you prefer this to be configurable?

@shinebayar-g
Copy link
Author

Oh I see. Well it was a little bit unexpected since instructions present 3 options and 2 of them doesn't clear up instructions while only 1 of them cleared it. I'd prefer it to be stay consistent tbh. My vote goes to non-clearing path by default. Configuration option doesn't sound bad.

@SBoudrias
Copy link
Owner

Let's combine this request with #963

@SBoudrias
Copy link
Owner

PR #1381 is up with this feature. I'll leave open a few days for review and feedback. Feel free to chip in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants