Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] 0013 Configuration #787

Merged
merged 6 commits into from
Apr 27, 2023
Merged

[RFC] 0013 Configuration #787

merged 6 commits into from
Apr 27, 2023

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Feb 19, 2023 •
edited
Loading

@matz3 matz3 added the RFC Request for Comment (pull request) label Mar 8, 2023
@RandomByte RandomByte requested a review from a team April 27, 2023 08:56
@RandomByte
Copy link
Member Author

This has been implemented with SAP/ui5-project#575 and SAP/ui5-cli#618. I updated the RFC and think that it's ready to be merged.

@d3xter666
Copy link
Contributor

LGTM

@RandomByte RandomByte merged commit 1dc50c1 into main Apr 27, 2023
@RandomByte RandomByte deleted the rfc-configuration branch April 27, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
RFC Request for Comment (pull request)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomByte @d3xter666 @matz3