-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTERNAL] Document the UI5 Tooling benchmarking process #466
Conversation
PRs where this process was already used: * SAP/ui5-builder#488 * SAP/ui5-builder#390 JIRA: CPOUI5FOUNDATION-261
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something missing in Line 75, otherwise just minor suggestions.
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
6dae314
to
1cc52aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions.
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
Thanks! I applied all suggestions 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PRs where this process was already used:
JIRA: CPOUI5FOUNDATION-261