Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Document the UI5 Tooling benchmarking process #466

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

RandomByte
Copy link
Member

PRs where this process was already used:
* SAP/ui5-builder#488
* SAP/ui5-builder#390

JIRA: CPOUI5FOUNDATION-261
matz3
matz3 previously approved these changes Dec 7, 2020
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something missing in Line 75, otherwise just minor suggestions.

docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions.

docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
docs/pages/Troubleshooting.md Outdated Show resolved Hide resolved
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
@RandomByte
Copy link
Member Author

Thanks! I applied all suggestions 👍

Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte RandomByte merged commit 4c68db5 into master Jan 21, 2021
@RandomByte RandomByte deleted the document-cli-benchmarking branch January 21, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants