[INTERNAL] Adapt project configuration documentation #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Thodd
commented
Jul 24, 2019
Thodd
commented
- Cachebuster docu is moved to correct location
- *.properties file encoding option is documented
- Cachebuster docu is moved to correct location - *.properties file encoding option is documented
matz3
reviewed
Jul 26, 2019
docs/pages/Configuration.md
Outdated
| @@ -87,8 +87,9 @@ Some general information: | |||
| + `<virtual path>: <physical path>` (default `/: ./`): Any virtual path mapping can be defined here. | |||
| *(Only available for projects of type `module`)* | |||
| It is recommended that modules include their namespace in the virtual path and use the `/resources` prefix (e.g. `/resources/my/first/library/module-xy`). | |||
| - `cachebuster`: | |||
| - `signatureType`: `time` or `hash`. By default, the generated cachebuster info file signatures are based on timestamps (`time`). In setups like CI environments, a mechanism based on file hashes (`hash`) might be more reliable. | |||
| - `propertiesFileEncoding`: | |||
There was a problem hiding this comment.
We should maybe also add the min. required CLI version for this (once released).
There was a problem hiding this comment.
Done. Expected to be released with UI5 CLI v1.7.0.
Thodd
commented
Jul 26, 2019
docs/pages/Configuration.md
Outdated
| @@ -87,8 +87,9 @@ Some general information: | |||
| + `<virtual path>: <physical path>` (default `/: ./`): Any virtual path mapping can be defined here. | |||
| *(Only available for projects of type `module`)* | |||
| It is recommended that modules include their namespace in the virtual path and use the `/resources` prefix (e.g. `/resources/my/first/library/module-xy`). | |||
| - `cachebuster`: | |||
| - `signatureType`: `time` or `hash`. By default, the generated cachebuster info file signatures are based on timestamps (`time`). In setups like CI environments, a mechanism based on file hashes (`hash`) might be more reliable. | |||
| - `propertiesFileEncoding`: | |||
There was a problem hiding this comment.
- moved to "resources.configuration"
- rename according to impl.
tobiasso85
approved these changes
Jul 31, 2019
RandomByte
previously requested changes
Jul 31, 2019
RandomByte
force-pushed
the
adapt-project-config-documentation
branch
from
37f5210
to
816a8b3
Compare
matz3
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.