[FEATURE] Enhance versionInfo middleware to serve sap-ui-version.json #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
previously approved these changes
Oct 18, 2021
Enhance the UI5 Server middleware 'versionInfo' to also serve the transitive information in the sap-ui-version.json as it would be generated with the UI5 Builder. JIRA: CPOUI5FOUNDATION-299
larskissel
force-pushed
the
enhanceVersionInfoMiddleware
branch
from
b58e712
to
1acf83a
Compare
matz3
reviewed
Oct 19, 2021
| mock.stopAll(); | ||
| }); | ||
|
|
||
| test.serial("todo", async (t) => { |
matz3
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the UI5 Server middleware 'versionInfo' to also serve
the transitive information in the sap-ui-version.json as it
would be generated with the UI5 Builder.
Depends on SAP/ui5-builder#648
JIRA: CPOUI5FOUNDATION-299