-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Prefer local over global CLI version #59
Conversation
|
Pull Request Test Coverage Report for Build 310
💛 - Coveralls |
784f323
to
71b1daa
Compare
rebased |
71b1daa
to
c76d0a3
Compare
Is "Prefer local over global CLI version" really a fix or rather a feature? I would opt for the latter |
Yes, I think feature is a better fit. |
When running the global "ui5" command while a local @ui5/cli version is installed for the current project, the local one should be preferred. Fixes: #58
c76d0a3
to
31a8180
Compare
Also document "prefer local" feature and add environment variable to disable it.
31a8180
to
bc59b85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RandomByte good idea. This also helps to see whether a locally linked ui5-cli project is used. But the ENV var is strange. I would expect to have a general "UI5 CLI" prefix that could be used in future for more variables, like About the |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Seems that you need to approve as I'm the author.
2f4ca4b
to
78c6ee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to update the README with the new environment variable name. Seems to be all good now. Yours to merge.
Note (just came to my mind): When using a CLI release containing this change in a repository that uses a release without it, no |
Yes, that's correct, but I think this can be neglected. |
When running the global "ui5" command while a local @ui5/cli version is
installed for the current project, the local one should be preferred.
Fixes: #58