[FIX] ui5 use: Corrupt UI5 configuration

Fixes: SAP/ui5-tooling#474

lib/framework/updateYaml.js

@@ -71,9 +71,16 @@ function applyChanges(string, changes) {
 				value: change.value
 			};
 		} else if (change.type === "insert") {
+			let startIndex = positionToIndex(change.parentPosition.end);
+			if (change.parentPosition.end.column > 1) {
+				// When end.column is not 1 we expect it to be the end of the line
+				// so the index needs to be increased by 1 to insert into the next line
+				startIndex++;
+			}
+			const endIndex = startIndex;
 			return {
-				startIndex: positionToIndex(change.parentPosition.end) + 1,
-				endIndex: positionToIndex(change.parentPosition.end) + 1,
+				startIndex,
+				endIndex,
 				value: change.value
 			};
 		}

test/lib/framework/updateYaml.js

@@ -819,3 +819,41 @@ metadata:
 	t.is(error.message, "Could not find project with name my-project-3 in YAML: ui5.yaml");
 	t.is(t.context.fsWriteFileStub.callCount, 0, "fs.writeFile should not be called");
 });
+
+test.serial("Should add version property to object", async (t) => {
+	t.context.fsReadFileStub.yieldsAsync(null, `
+metadata:
+  name: my-project
+framework:
+  name: OpenUI5
+  libraries:
+    - name: sap.ui.core
+something: else
+`);
+
+	await updateYaml({
+		project: {
+			path: "my-project",
+			metadata: {"name": "my-project"}
+		},
+		data: {
+			framework: {
+				version: "1.85.0"
+			}
+		}
+	});
+
+	t.is(t.context.fsWriteFileStub.callCount, 1, "fs.writeFile should be called once");
+	t.deepEqual(t.context.fsWriteFileStub.getCall(0).args[0], path.join("my-project", "ui5.yaml"),
+		"writeFile should be called with expected path");
+	t.deepEqual(t.context.fsWriteFileStub.getCall(0).args[1], `
+metadata:
+  name: my-project
+framework:
+  name: OpenUI5
+  libraries:
+    - name: sap.ui.core
+  version: "1.85.0"
+something: else
+`, "writeFile should be called with expected content");
+});