Skip to content

Commit

Permalink
[INTERNAL] package.json: Update dependency opn to open
Browse files Browse the repository at this point in the history
The project "opn" is deprecated because it got renamed to "open".
  • Loading branch information
svbender authored and RandomByte committed Mar 28, 2019
1 parent f234613 commit 0609e4f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions lib/cli/commands/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ serve.handler = function(argv) {
}
browserUrl += relPath;
}
const opn = require("opn");
opn(browserUrl);
const open = require("open");
open(browserUrl);
}

return browserUrl;
Expand Down
6 changes: 3 additions & 3 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"@ui5/server": "^1.0.0",
"import-local": "^2.0.0",
"js-yaml": "^3.13.0",
"opn": "^6.0.0",
"open": "^6.0.0",
"semver": "^6.0.0",
"supports-color": "^6.0.0",
"treeify": "^1.0.1",
Expand Down
8 changes: 4 additions & 4 deletions test/lib/cli/commands/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@ test.serial("ui5 serve --accept-remote-connections", async (t) => {
test.serial("ui5 serve --open", async (t) => {
normalizerStub.resolves(projectTree);
serverStub.resolves({port: 8080});
mockRequire("opn", function(openedUrl) {
mockRequire("open", function(openedUrl) {
t.is(openedUrl, "http://localhost:8080/webapp/index.html", `Opens url: ${openedUrl}`);
mockRequire.stop("opn");
mockRequire.stop("open");
});
await serve.handler(
Object.assign({}, defaultInitialHandlerArgs, {open: "webapp/index.html"})
Expand All @@ -122,9 +122,9 @@ test.serial("ui5 serve --open", async (t) => {
test.serial("ui5 serve --open (opens default url)", async (t) => {
normalizerStub.resolves(projectTree);
serverStub.resolves({port: 8080});
mockRequire("opn", function(openedUrl) {
mockRequire("open", function(openedUrl) {
t.is(openedUrl, "http://localhost:8080", `Opens url: ${openedUrl}`);
mockRequire.stop("opn");
mockRequire.stop("open");
});
await serve.handler(
Object.assign({}, defaultInitialHandlerArgs, {open: true})
Expand Down

0 comments on commit 0609e4f

Please sign in to comment.