[INTERNAL] Apply suggestions from UA review

Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
SAP · Apr 25, 2023 · 04fdf8d · 04fdf8d
1 parent 19122b5
commit 04fdf8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/cli/commands/config.js b/lib/cli/commands/config.js
@@ -11,7 +11,7 @@ const configCommand = {
 
 configCommand.builder = function(cli) {
 	return cli
-		.demandCommand(1, "Command required. Available commands are 'set', 'get' and 'list'")
+		.demandCommand(1, "Command required. Available commands are 'set', 'get', and 'list'")
 		.command("set <key> [value]", "Set the value for a given configuration key. " +
 			"Clear an existing configuration by omitting the value", {
 			handler: handleConfig,

diff --git a/test/lib/cli/commands/config.js b/test/lib/cli/commands/config.js
@@ -138,7 +138,7 @@ test.serial("ui5 config set", async (t) => {
 	}, "Configuration#toFile got called with expected argument");
 });
 
-test.serial("ui5 config set without value should delete", async (t) => {
+test.serial("ui5 config set without a value should delete the configuration", async (t) => {
 	const {config, argv, stderrWriteStub, stdoutWriteStub, Configuration} = t.context;
 
 	argv["_"] = ["set"];
@@ -157,7 +157,7 @@ test.serial("ui5 config set without value should delete", async (t) => {
 	}, "Configuration#toFile got called with expected argument");
 });
 
-test.serial("ui5 config set empty value should delete", async (t) => {
+test.serial("ui5 config set with an empty value should delete the configuration", async (t) => {
 	const {config, argv, stderrWriteStub, stdoutWriteStub, Configuration} = t.context;
 
 	argv["_"] = ["set"];
@@ -176,7 +176,7 @@ test.serial("ui5 config set empty value should delete", async (t) => {
 	}, "Configuration#toFile got called with expected argument");
 });
 
-test.serial("ui5 config set null should update", async (t) => {
+test.serial("ui5 config set null should update the configuration", async (t) => {
 	const {config, argv, stderrWriteStub, stdoutWriteStub, Configuration} = t.context;
 
 	argv["_"] = ["set"];
@@ -199,7 +199,7 @@ test.serial("ui5 config set null should update", async (t) => {
 	}, "Configuration#toFile got called with expected argument");
 });
 
-test.serial("ui5 config set false should update", async (t) => {
+test.serial("ui5 config set false should update the configuration", async (t) => {
 	const {config, argv, stderrWriteStub, stdoutWriteStub, Configuration} = t.context;
 
 	argv["_"] = ["set"];