Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Validate apiVersion property in Library.init #943

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[FEATURE] Validate apiVersion property in Library.init #943

merged 1 commit into from
Oct 10, 2023

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-730

@coveralls
Copy link

Coverage Status

coverage: 94.432% (+0.005%) from 94.427% when pulling 2e00432 on validate-apiVersion into 30c4c14 on main.

@d3xter666 d3xter666 requested a review from a team October 6, 2023 11:05
RandomByte
RandomByte approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + positive manual test in the core library 👍

@d3xter666 d3xter666 merged commit 52bf258 into main Oct 10, 2023
17 checks passed
@d3xter666 d3xter666 deleted the validate-apiVersion branch October 10, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3xter666 @coveralls @RandomByte