Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] builder: add cssVariables option #728

Merged
merged 6 commits into from
Apr 5, 2022
Merged

[FEATURE] builder: add cssVariables option #728

merged 6 commits into from
Apr 5, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Mar 30, 2022 •
edited
Loading

Add cssVariables option in the UI5-Builder.
BLI: CPOUI5FOUNDATION-346

@flovogt flovogt mentioned this pull request Mar 30, 2022
Closed
@flovogt flovogt requested a review from matz3 March 30, 2022 13:33
@coveralls
Copy link

coveralls commented Mar 31, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 94.82% when pulling be326f5 on css-variables-api-next into ebb93f5 on next.

matz3
matz3 reviewed Apr 1, 2022
View reviewed changes
lib/tasks/TaskUtil.js Outdated Show resolved Hide resolved
lib/builder/ProjectBuildContext.js Show resolved Hide resolved
@flovogt flovogt changed the title [FEAT]: enable build with CSS variables [FEAT]: builder: add cssVariables option Apr 4, 2022
@flovogt flovogt changed the title [FEAT]: builder: add cssVariables option [FEATURE] builder: add cssVariables option Apr 4, 2022
@flovogt flovogt requested a review from KlattG April 4, 2022 13:53
matz3
matz3 previously approved these changes Apr 5, 2022
View reviewed changes
KlattG
KlattG suggested changes Apr 5, 2022
View reviewed changes
lib/tasks/TaskUtil.js Outdated Show resolved Hide resolved
@flovogt flovogt merged commit 30d58e1 into next Apr 5, 2022
@flovogt flovogt deleted the css-variables-api-next branch April 5, 2022 12:20
@flovogt flovogt mentioned this pull request Apr 6, 2022
Merged
This was referenced May 4, 2022
Closed
Closed
@matz3 matz3 mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG requested changes

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovogt @coveralls @matz3 @KlattG