[INTERNAL] Export build processor manifestCreator

index.js

@@ -49,6 +49,10 @@ module.exports = {
 		 * @type {import('./lib/processors/libraryLessGenerator')}
 		 */
 		libraryLessGenerator: "./lib/processors/libraryLessGenerator",
+		/**
+		 * @type {import('./lib/processors/manifestCreator')}
+		 */
+		manifestCreator: "./lib/processors/manifestCreator",
 		/**
 		 * @type {import('./lib/processors/resourceCopier')}
 		 */

lib/processors/manifestCreator.js

@@ -157,7 +157,7 @@ class LibraryBundle {
 /*
  * Creates the library manifest.json file for a UILibrary.
  */
-async function createManifest(libraryResource, libBundle, descriptorVersion, _include3rdParty) {
+async function createManifest(libraryResource, libBundle, descriptorVersion, _include3rdParty, minUI5VersionRequired) {
 	// create a Library wrapper around the .library XML
 	const library = await Library.from(libraryResource);
 
@@ -604,7 +604,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 	}
 
 	function normalizeVersion(version) {
-		if ( version == null ) {
+		if ( version == null || !minUI5VersionRequired && !version ) {
 			return version;
 		}
 		const v = new Version(version);
@@ -634,6 +634,10 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 			}
 		}
 
+		if ( !minUI5VersionRequired ) {
+			return "";
+		}
+
 		throw new Error(
 			`Couldn't find version for library '${dependency.getLibraryName()}', project dependency missing?`);
 	}
@@ -652,9 +656,10 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 module.exports = function({libraryResource, resources, options}) {
 	// merge options with defaults
 	options = Object.assign({
-		descriptorVersion: APP_DESCRIPTOR_V22, // TODO change this to type string instead of a semver object
+		descriptorVersion: APP_DESCRIPTOR_V22, // TODO 3.0: change this to type string instead of a semver object
 		include3rdParty: true,
-		prettyPrint: true
+		prettyPrint: true,
+		minUI5VersionRequired: true
 	}, options);
 
 	const resourcePathPrefix = libraryResource.getPath().slice(0, -".library".length);
@@ -667,7 +672,8 @@ module.exports = function({libraryResource, resources, options}) {
 		return Promise.resolve(null); // a fulfillment of null indicates that no manifest has been created
 	}
 
-	return createManifest(libraryResource, libBundle, options.descriptorVersion, options.include3rdParty)
+	return createManifest(libraryResource, libBundle, options.descriptorVersion, options.include3rdParty,
+		options.minUI5VersionRequired)
 		.then((manifest) => {
 			return new EvoResource({
 				path: resourcePathPrefix + "manifest.json",

test/lib/processors/manifestCreator.js

@@ -348,6 +348,74 @@ test.serial("default manifest creation no dependency version", async (t) => {
 		"Couldn't find version for library 'my.lib', project dependency missing?", "error message correct");
 });
 
+test.serial("manifest creation no minUI5Version required", async (t) => {
+	const {manifestCreator, errorLogStub} = t.context;
+
+	const expectedManifestContent = JSON.stringify({
+		"_version": "1.21.0",
+		"sap.app": {
+			"id": "library.e",
+			"type": "library",
+			"embeds": [],
+			"applicationVersion": {},
+			"title": "Library E",
+			"description": "Library E",
+			"resources": "resources.json",
+			"offline": true
+		},
+		"sap.ui": {
+			"technology": "UI5",
+			"supportedThemes": []
+		},
+		"sap.ui5": {
+			"dependencies": {
+				"minUI5Version": "",
+				"libs": {
+					"my.lib": {
+						"minVersion": ""
+					}
+				}
+			},
+			"library": {
+				"i18n": false
+			}
+		}
+	}, null, 2);
+
+	const libraryResource = {
+		getPath: () => {
+			return "/resources/sap/ui/mine/.library";
+		},
+		getString: async () => {
+			return `<?xml version="1.0" encoding="UTF-8" ?>
+				<library xmlns="http://www.sap.com/sap.ui.library.xsd" >
+					<name>library.e</name>
+					<vendor>SAP SE</vendor>
+					<documentation>Library E</documentation>
+					<dependencies>
+					    <dependency>
+					      <libraryName>my.lib</libraryName>
+					    </dependency>
+					</dependencies>
+				</library>`;
+		},
+		_project: {
+			dependencies: []
+		}
+	};
+
+	const result = await manifestCreator({
+		libraryResource,
+		resources: [],
+		options: {
+			minUI5VersionRequired: false
+		}
+	});
+
+	t.is(await result.getString(), expectedManifestContent, "Correct result returned");
+	t.is(errorLogStub.callCount, 0);
+});
+
 test.serial("default manifest creation with special characters", async (t) => {
 	const {manifestCreator, errorLogStub} = t.context;
 	const prefix = "/resources/sap/ui/mine/";