[FIX] LibraryFormatter: Do not throw for missing .library in legacy OpenUI5 theme libraries #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penUI5 theme libraries Exception handling was already in place for legacy OpenUI5 theme libraries that still use type 'library' instead of 'theme-library': #437 This allowed them to still be formatted even though they are missing a .library file. However, the newly added preload exclude configuration fallback for framework libraries also requires a .library file and did not make the mentioned exception for legacy OpenUI5 theme libraries: #573 This fix adds that exception and the tests that were missing from #437
matz3
approved these changes
Mar 9, 2021
| sinon.stub(libraryFormatter, "validate").resolves(); | ||
|
|
||
| await t.notThrowsAsync(libraryFormatter.format(), "Does not throw for missing .library"); | ||
| t.deepEqual(myProject.metadata.copyright, legacyThemeLibTree.metadata.copyright, "Copyright was not altered"); |
There was a problem hiding this comment.
Probably a leftover from another test, right?
There was a problem hiding this comment.
Well yes but I still found it to be valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception handling was already in place for legacy OpenUI5 theme
libraries that still use type 'library' instead of 'theme-library': #437
This allowed them to still be formatted even though they are missing a
.library file.
However, the newly added preload exclude configuration fallback for
framework libraries also requires a .library file and did not make the
mentioned exception for legacy OpenUI5 theme libraries: #573
This fix adds that exception and the tests that were missing from #437