Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Add manifestCreator to processors facade #556

Closed
wants to merge 1 commit into from
Closed

[INTERNAL] Add manifestCreator to processors facade #556

wants to merge 1 commit into from

Conversation

codeworrior
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.195% when pulling 668d0bd on add-manifestCreator-to-processors-facade into 3e99c36 on master.

matz3
matz3 requested changes Nov 30, 2020
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifestCreator has no JSDoc, so we should not make it available to be imported.
We should also add JSDoc and with that maybe re-check the public API.

RandomByte
RandomByte previously requested changes Nov 30, 2020
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discarding my approval

@RandomByte RandomByte dismissed their stale review November 30, 2020 16:42

Ongoing discussion with matz3

@matz3 matz3 mentioned this pull request Feb 25, 2021
Merged
@larskissel larskissel mentioned this pull request Oct 4, 2021
Merged
@RandomByte
Copy link
Member

Done with #648

@RandomByte RandomByte closed this Sep 22, 2022
@RandomByte RandomByte deleted the add-manifestCreator-to-processors-facade branch September 22, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 requested changes

@RandomByte RandomByte RandomByte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codeworrior @coveralls @RandomByte @matz3