[FIX] Ensure proper handling of multi-byte characters in streams #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeworrior
reviewed
Feb 5, 2020
The stream encoding needs to be set in order to properly handle multi-byte utf8 characters that are split between different chunks. See: https://nodejs.org/api/stream.html#stream_readable_setencoding_encoding
matz3
force-pushed
the
fix-stringReplacer-encoding
branch
from
d84b5b2
to
c411974
Compare
|
It seems that the fix doesn't work for Node 8... |
|
Let's fix this with version 2.0 |
|
Or we skip the test in Node 8? |
|
Great idea, let's do that 👍 |
RandomByte
approved these changes
Feb 6, 2020
|
Related: SAP/ui5-server#280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream encoding needs to be set in order to properly handle
multi-byte utf8 characters that are split between different chunks.
See:
https://nodejs.org/api/stream.html#stream_readable_setencoding_encoding