[FEATURE] flexChangesBundler: Add flexibility-bundle.json #353

thuyboehm · 2019-10-15T09:10:24Z

[INTERNAL] If minUI5Version >= 1.73 flexibility-bundle.json is create indeed of changes-bundle.json
If minUI5Version < 1.73 and there are no control variant changes changes-bundle.json is create.
If minUI5Version < 1.73 and there are control variant changes the build will throw an error.

CLAassistant · 2019-10-15T09:10:52Z

All committers have signed the CLA.

coveralls · 2019-10-15T09:13:26Z

Coverage increased (+0.2%) to 90.276% when pulling 7d77213 on thuyboehm:addFlexBundleJson into b2d8269 on SAP:master.

codeworrior · 2019-10-15T09:14:44Z

lib/tasks/bundlers/generateFlexChangesBundle.js

+		// if there are ctrl variant and minUI5Version < 1.72 need to update minUI5Version to 1.72.0
+		if (hasVariant && !hasFlexBundleVersion) {
+			log.verbose("minUI5Version < 1.72, updated it to 1.72.0");
+			data["sap.ui5"].dependencies.minUI5Version = "1.72.0";


IMHO, the tooling must not change manifest metadata on the fly, it should rather stop with an error.

Thanks, I change the logic.
The build will stop when the minUI5Version is below 1.72 and there are control variants in the change folder

RandomByte · 2019-10-15T11:32:29Z

Please prefix your commit message with [INTERNAL] as per our Contributing Guidelines

…s below 1.72

codeworrior

Basically okay with me. Most comments are style comments (a matter of taste). The most important point IMO is the missing explanation of the new format. What files are stored in what array etc.

lib/processors/bundlers/flexChangesBundler.js

lib/tasks/bundlers/generateFlexChangesBundle.js

lib/processors/bundlers/flexChangesBundler.js

lib/tasks/bundlers/generateFlexChangesBundle.js

lib/processors/bundlers/flexChangesBundler.js

lib/tasks/bundlers/generateFlexChangesBundle.js

lib/processors/bundlers/flexChangesBundler.js

codeworrior

LGTM now.

RandomByte · 2019-11-07T13:08:59Z

Had a rough look, lgtm. @codeworrior feel free to merge 👍

RandomByte · 2019-11-07T13:35:18Z

Just wondering, is this an [INTERNAL] or a [FEATURE] change?

RandomByte · 2019-11-07T16:38:04Z

Released as part of UI5 CLI v1.12.0 🎉

shahzeb79 · 2020-07-20T18:21:08Z

Hi All,
I get this Error.
Error: There are some control variant changes in the changes folder. This only works with a minUI5Version 1.73.0. Please update the minUI5Version in the manifest.json to 1.73.0 or higher

What should be done to avoid this error?

codeworrior · 2020-07-20T19:22:34Z

@shahzeb79 I would say, the error message is quite instructive, isn't it?

Or aren't there any variant changes in the app or does it already use a min version of 1.73.0 or higher? Can you please point us to the app's sources or to a build log, for further analysis?

shahzeb79 · 2020-07-20T20:58:26Z

Hi,
Our app dont have hardcoded version for minUI5Version. <removed internal URL from public GitHub - RandomByte>

Here is the link for the app having this error. <removed internal URL from public GitHub - RandomByte>

codeworrior · 2020-07-21T03:45:53Z

I see. I guess the Maven property ${sap.ui5.dist.version} is not resolved during build execution before the flexBundler reads and analyzes the manifest.json.

Is Maven filtering (or an equivalent) active in your build before the ui5 tooling is executed? As the project resources rely on Maven properties, such a step is required anywhere. The ui5 tooling to my knowledge only can replace the version and copyright properties. @RandomByte, @matz3 or can the set of properties (and their values) be configured somehow?

RandomByte · 2020-07-21T08:21:15Z

The ui5 tooling to my knowledge only can replace the version and copyright properties. @RandomByte, @matz3 or can the set of properties (and their values) be configured somehow?

No. Of course you could add replacement for other strings in a custom middleware however.

shahzeb79 · 2020-07-21T19:19:52Z

@codeworrior no we dont do any mvn thing before ui5tooling now. Do you think we have to issue some mvn command ?

matz3 · 2020-07-22T07:02:40Z

No. Of course you could add replacement for other strings in a custom middleware however.

But as there's no way to write back the modified resources it's not possible for the flexChangesBundler to receive it.
So I think it's not straight-forward to solve.

@codeworrior no we dont do any mvn thing before ui5tooling now. Do you think we have to issue some mvn command ?

You might process the resources via maven (with filtering) and then use the "target" folder for running the UI5 Tooling and karma tests

RandomByte · 2020-07-22T10:39:23Z

But as there's no way to write back the modified resources it's not possible for the flexChangesBundler to receive it.

I think I meant custom task. There this should be possible, shouldn't it?

matz3 · 2020-07-22T10:45:28Z

I think I meant custom task. There this should be possible, shouldn't it?

Yes, there it's possible.

shahzeb79 · 2020-07-22T10:51:27Z

@matz3 Yes we can run mvn to generate target

RandomByte · 2020-07-22T13:32:42Z

@shahzeb79 have you seen my comment in your other issue: SAP/ui5-tooling#245 (comment) ?

I think what @matz3 suggests might be a good workaround but the better solution would be the outcome of SAP/ui5-tooling#245 (comment) where you can work with flex changes directly from source.

add flexibility-bundle.json

f2899e5

codeworrior reviewed Oct 15, 2019

View reviewed changes

thuyboehm added 4 commits October 15, 2019 16:14

[INTERNAL] throw error if there is a ctrl_variant and minUI5Version i…

09c3ec0

…s below 1.72

[INTERNAL] update comment

021566e

[INTERNAL] add file_type variant for compVariants

e340e2a

[INTERNAL] change minUI5Version to 1.73

3b9acc9

codeworrior requested changes Oct 28, 2019

View reviewed changes

[INTERNAL] change comment, optimize some lines

3f30fd0

codeworrior reviewed Nov 5, 2019

View reviewed changes

[INTERNAL] change comment and change read manifest

7d77213

codeworrior self-requested a review November 7, 2019 13:01

codeworrior approved these changes Nov 7, 2019

View reviewed changes

RandomByte changed the title ~~[INTERNAL] add flexibility-bundle.json~~ [FEATURE] flexChangesBundler: Add flexibility-bundle.json Nov 7, 2019

RandomByte merged commit cecc97d into SAP:master Nov 7, 2019

matz3 mentioned this pull request Mar 16, 2020

Changes made by Visual Editor for Fiori Elements not included in dist folder. SAP-archive/grunt-openui5#149

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] flexChangesBundler: Add flexibility-bundle.json #353

[FEATURE] flexChangesBundler: Add flexibility-bundle.json #353

thuyboehm commented Oct 15, 2019 •

edited

Loading

CLAassistant commented Oct 15, 2019 •

edited

Loading

coveralls commented Oct 15, 2019 •

edited

Loading

codeworrior Oct 15, 2019

thuyboehm Oct 16, 2019

RandomByte commented Oct 15, 2019

codeworrior left a comment

codeworrior left a comment

RandomByte commented Nov 7, 2019 •

edited

Loading

RandomByte commented Nov 7, 2019

RandomByte commented Nov 7, 2019

shahzeb79 commented Jul 20, 2020

codeworrior commented Jul 20, 2020

shahzeb79 commented Jul 20, 2020 •

edited by RandomByte

Loading

codeworrior commented Jul 21, 2020

RandomByte commented Jul 21, 2020

shahzeb79 commented Jul 21, 2020

matz3 commented Jul 22, 2020

RandomByte commented Jul 22, 2020

matz3 commented Jul 22, 2020

shahzeb79 commented Jul 22, 2020

RandomByte commented Jul 22, 2020

[FEATURE] flexChangesBundler: Add flexibility-bundle.json #353

[FEATURE] flexChangesBundler: Add flexibility-bundle.json #353

Conversation

thuyboehm commented Oct 15, 2019 • edited Loading

CLAassistant commented Oct 15, 2019 • edited Loading

coveralls commented Oct 15, 2019 • edited Loading

codeworrior Oct 15, 2019

Choose a reason for hiding this comment

thuyboehm Oct 16, 2019

Choose a reason for hiding this comment

RandomByte commented Oct 15, 2019

codeworrior left a comment

Choose a reason for hiding this comment

codeworrior left a comment

Choose a reason for hiding this comment

RandomByte commented Nov 7, 2019 • edited Loading

RandomByte commented Nov 7, 2019

RandomByte commented Nov 7, 2019

shahzeb79 commented Jul 20, 2020

codeworrior commented Jul 20, 2020

shahzeb79 commented Jul 20, 2020 • edited by RandomByte Loading

codeworrior commented Jul 21, 2020

RandomByte commented Jul 21, 2020

shahzeb79 commented Jul 21, 2020

matz3 commented Jul 22, 2020

RandomByte commented Jul 22, 2020

matz3 commented Jul 22, 2020

shahzeb79 commented Jul 22, 2020

RandomByte commented Jul 22, 2020

thuyboehm commented Oct 15, 2019 •

edited

Loading

CLAassistant commented Oct 15, 2019 •

edited

Loading

coveralls commented Oct 15, 2019 •

edited

Loading

RandomByte commented Nov 7, 2019 •

edited

Loading

shahzeb79 commented Jul 20, 2020 •

edited by RandomByte

Loading