Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Builder: Handle files without extension #637

Merged
merged 3 commits into from
Aug 25, 2021
Merged

[FIX] Builder: Handle files without extension #637

merged 3 commits into from
Aug 25, 2021

Conversation

kristian
Copy link
Member

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@kristian kristian mentioned this pull request Aug 21, 2021
Closed
@coveralls
Copy link

coveralls commented Aug 21, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 94.698% when pulling b8669b2 on kristian:fix546 into 7490fb1 on SAP:master.

@matz3 matz3 self-assigned this Aug 25, 2021
@matz3
[INTERNAL] Also fix pattern for resources.json, rename test file
88d5b13
@matz3
[INTERNAL] Add back leading slash in pattern
b8669b2 
Seems to also work without, but as ALL resources of the workspace should
be written, the more explicit pattern should be used.
@matz3 matz3 changed the title [FIX] Fixes: #546 [FIX] Builder: Handle files without extension Aug 25, 2021
@matz3 matz3 added the bug Something isn't working label Aug 25, 2021
@matz3 matz3 merged commit 07aaa24 into SAP:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

Assignees

@matz3 matz3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristian @coveralls @matz3