Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder does not build extention-less files #546

Closed
kristian opened this issue Aug 20, 2021 · 1 comment
Closed

builder does not build extention-less files #546

kristian opened this issue Aug 20, 2021 · 1 comment
Assignees
Labels
bug Something isn't working module/ui5-builder Related to the UI5 Builder module

Comments

@kristian
Copy link
Member

kristian commented Aug 20, 2021

Expected Behavior

Writing a file without a extension to be copied to the dist directory.

Current Behavior

File without extension is not copied.

Context

Guess the culprit lies in the following glob in the builder: https://github.com/SAP/ui5-builder/blob/master/lib/builder/builder.js#L375

When writing out all the resources builder does:

return workspace.byGlob("/**/*.*").then((resources) => {

Should be:

return workspace.byGlob("**/*").then((resources) => {

Or is it by design?

@kristian kristian added bug Something isn't working needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Aug 20, 2021
@kristian
Copy link
Member Author

Fixed by SAP/ui5-builder#637

@matz3 matz3 self-assigned this Aug 25, 2021
@matz3 matz3 added module/ui5-builder Related to the UI5 Builder module and removed needs triage Needs to be investigated and confirmed as a valid issue that is not a duplicate labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Development

No branches or pull requests

2 participants