[INTERNAL] Fix embeddedBy check

SAP · Nov 30, 2020 · 75377ac · 75377ac
1 parent 7c8573a
commit 75377ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/processors/manifestCreator.js b/lib/processors/manifestCreator.js
@@ -176,10 +176,10 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
 				return false;
 			}
 			let embeddedBy;
-			if (manifest && manifest["sap.app"] && typeof manifest["sap.app"]["embeddedBy"] !== "undefined") {
+			if (manifest && manifest["sap.app"]) {
 				embeddedBy = manifest["sap.app"]["embeddedBy"];
 			}
-			if (embeddedBy == null) {
+			if (typeof embeddedBy === "undefined") {
 				log.verbose("  component doesn't declare 'sap.app/embeddedBy', don't list it as 'embedded'");
 				return false;
 			}

diff --git a/test/lib/processors/manifestCreator.js b/test/lib/processors/manifestCreator.js
@@ -413,9 +413,7 @@ test.serial("manifest creation with embedded component (Missing 'embeddedBy')",
 			return "/resources/sap/lib1/component1/manifest.json";
 		},
 		getString: async () => {
-			return JSON.stringify({
-				"sap.app": {}
-			});
+			return JSON.stringify({});
 		}
 	};