Skip to content

Commit

Permalink
[INTERNAL] Apply suggestions from UA review
Browse files Browse the repository at this point in the history
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
  • Loading branch information
RandomByte and KlattG committed Oct 6, 2023
1 parent c713f15 commit 390fb81
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions lib/processors/minifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ async function getSourceMapFromUrl({sourceMappingUrl, resourcePath, readFile}) {
* Required when using the <code>useWorkers</code> option
* @param {object} [parameters.options] Options
* @param {boolean} [parameters.options.readSourceMappingUrl=false]
* Whether to make use of any existing source maps referenced in the resources to be minified. Use this to preserve
* the reference to the original source files, such as TypeScript files, in the generated source map.<br>
* If a resource has been modified by a previous tasks, any existing source map will be ignored regardless of this
* setting. This is to ensure that no inconsistent source maps are being used. Check verbose log for details.
* Whether to make use of any existing source maps referenced in the resources to be minified. Use this option to
* preserve references to the original source files, such as TypeScript files, in the generated source map.<br>
* If a resource has been modified by a previous task, any existing source map will be ignored regardless of this
* setting. This is to ensure that no inconsistent source maps are used. Check the verbose log for details.
* @param {boolean} [parameters.options.addSourceMappingUrl=true]
* Whether to add a sourceMappingURL reference to the end of the minified resource
* @param {boolean} [parameters.options.useWorkers=false]
Expand Down
2 changes: 1 addition & 1 deletion lib/tasks/minify.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import fsInterface from "@ui5/fs/fsInterface";
* @param {boolean} [parameters.options.omitSourceMapResources=false] Whether source map resources shall
* be tagged as "OmitFromBuildResult" and no sourceMappingURL shall be added to the minified resource
* @param {boolean} [parameters.options.useInputSourceMaps=true] Whether to make use of any existing source
* maps referenced in the resources to be minified. Use this to preserve the reference to the original
* maps referenced in the resources to be minified. Use this option to preserve reference to the original
* source files, such as TypeScript files, in the generated source map.
* @returns {Promise<undefined>} Promise resolving with <code>undefined</code> once data has been written
*/
Expand Down

0 comments on commit 390fb81

Please sign in to comment.