Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate to ECMAScript 2022 syntax #207

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[FEATURE] Migrate to ECMAScript 2022 syntax #207

merged 1 commit into from
Aug 7, 2023

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Aug 6, 2023

Migrates openui5-sample-app to latest best practices based on ECMAScript 2022 syntax.

  • Use Arrow functions
  • Use Method definitions
  • Use const and let instead of var
  • Use eslint:recommended

Closes #205.

@flovogt flovogt merged commit e117736 into main Aug 7, 2023
5 checks passed
@flovogt flovogt deleted the es2022 branch August 7, 2023 11:28
.eslintrc.json Show resolved Hide resolved
flovogt added a commit that referenced this pull request Aug 15, 2023
Follow-up of
#207 (comment)

---------

Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
doeliang-take2 pushed a commit to doeliang-take2/SAPUI5-tutirial that referenced this pull request Dec 22, 2023
Follow-up of
SAP/openui5-sample-app#207 (comment)

---------

Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
rodinho pushed a commit to rodinho/sapui5 that referenced this pull request Jan 16, 2024
Follow-up of
SAP/openui5-sample-app#207 (comment)

---------

Co-authored-by: Matthias Osswald <mat.osswald@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants